Feature #293
refactoring of NmapOutput
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: |  Bartosz SKOWRON - |
% Done: | 0% |
|
| Category: | Umit | |||
| Target version: | - | |||
| Resolution: |
Description
Highlighting of nmap output contains some bugs (#289) and need general refactoring.
I will watch other functions from the NmapOutputView module too.
History
Updated by Bartosz SKOWRON - about 4 years ago
Currently I don't look at it. If someone wanna to take this ticket just accept it for yourself.
Updated by Bartosz SKOWRON - about 4 years ago
s/accept/assign
Updated by Luis A. Bastiao Silva about 4 years ago
Updated by Bartosz SKOWRON - about 4 years ago
Refactoring means refactoring. Check the code. I think it should be completely rewritten and optimized. Feel free to do it.
Updated by Luis A. Bastiao Silva almost 4 years ago
Replying to [comment:4 getxsick]:
Refactoring means refactoring. Check the code. I think it should be completely rewritten and optimized. Feel free to do it.
yeah. Firstly I need to know the reasons of refactor. There're some expressions that should be improved and there're a bugs like #298.
"Describe what you started doing then, and some kind of plan, please." by Guilherme.
Could you describe the plan please? What I have in mind is just fix the bugs.
Updated by Luis A. Bastiao Silva almost 4 years ago
Replying to [comment:5 luis]:
Replying to [comment:4 getxsick]:
Refactoring means refactoring. Check the code. I think it should be completely rewritten and optimized. Feel free to do it.
yeah. Firstly I need to know the reasons of refactor. There're some expressions that should be improved and there're a bugs like #298.
"Describe what you started doing then, and some kind of plan, please." by Guilherme.
Could you describe the plan please? What I have in mind is just fix the bugs.
s/298/289
Updated by anonymous - almost 4 years ago
I haven't defined any real plan of refactoring. I just checked a code and it seemed a lot of strange code. But I haven't digged deeply to understand it. So, can't say like: you have to write this and this. I don't have this knowledge of this part of code. But current code looks complex and excessive. So instead of fixing #289 (which propably need some effort in current state of code), would be nice to refactor and optimize the whole code.
Updated by Bartosz SKOWRON - almost 4 years ago
And this above is written by me. And I have no idea why trac allows for writting comments as an anonymous
Updated by Luis A. Bastiao Silva almost 4 years ago
Last week you said that didn't have sure about this ticket.
I'm not closing this. But for now I'm changing milestone because it's pointless for 1.0. I'm going to fix related bugs.
Updated by João Medeiros about 3 years ago
Just to avoid the use of deprecated components (see #292).